This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
chore(release): cut v1.1.0-rc.1 #4630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sarah Christoff <[email protected]>
Signed-off-by: Sarah Christoff <[email protected]>
schristoff
requested review from
shashankram,
snehachhabria,
nojnhuh,
draychev,
jaellio and
trstringer
as code owners
nojnhuh
suggested changes
Apr 4, 2022
.github/workflows/nightly-images.yml
Outdated
| @@ -10,7 +10,7 @@ jobs: | |||
| env: | |||
| DOCKER_USER: ${{ secrets.RELEASE_DOCKER_USER }} | |||
| DOCKER_PASS: ${{ secrets.RELEASE_DOCKER_PASS }} | |||
| CTR_TAG: latest-main | |||
| CTR_TAG: v1.1.0 | |||
There was a problem hiding this comment.
All of the CI config should stay the same
| @@ -43,7 +43,7 @@ var testPresetMeshConfigMap *corev1.ConfigMap = &corev1.ConfigMap{ | |||
| "logLevel": "error", | |||
| "maxDataPlaneConnections": 0, | |||
| "envoyImage": "envoyproxy/envoy-alpine:v1.19.3@sha256:874e699857e023d9234b10ffc5af39ccfc9011feab89638e56ac4042ecd4b0f3", | |||
| "initContainerImage": "openservicemesh/init:latest-main", | |||
| "initContainerImage": "openservicemesh/init:v1.1.0", | |||
There was a problem hiding this comment.
This test will still pass as-is, so we don't need to change this. If the test passes without this line at all, I'd also be in favor of removing it.
Codecov Report
@@ Coverage Diff @@
## release-v1.1 #4630 +/- ##
=============================================
Coverage 68.97% 68.97%
=============================================
Files 213 213
Lines 14861 14861
=============================================
Hits 10250 10250
Misses 4558 4558
Partials 53 53
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
nojnhuh
reviewed
Apr 4, 2022
jaellio
reviewed
Apr 4, 2022
charts/osm/Chart.yaml
Outdated
| @@ -18,7 +18,7 @@ version: 1.0.0 | |||
|
|
|||
| # This is the version number of the application being deployed. This version number should be | |||
| # incremented each time you make changes to the application. | |||
| appVersion: latest-main | |||
| appVersion: v1.1.0 | |||
There was a problem hiding this comment.
Are we cutting an RC first? v1.1.0-rc.1
Co-authored-by: Jon Huhn <[email protected]>
Co-authored-by: Jon Huhn <[email protected]>
Co-authored-by: Jon Huhn <[email protected]>
jaellio
reviewed
Apr 4, 2022
| @@ -18,7 +18,7 @@ version: 1.0.0 | |||
|
|
|||
There was a problem hiding this comment.
The version field should also be updated
Signed-off-by: Sarah Christoff <[email protected]>
shashankram
changed the title
Signed-off-by: Sarah Christoff <[email protected]>
jaellio
reviewed
Apr 4, 2022
| @@ -1,6 +1,6 @@ | |||
| # Open Service Mesh Helm Chart | |||
|
|
|||
|    | |||
|    | |||
There was a problem hiding this comment.
Suggested change
|    | |
|    |
nojnhuh
approved these changes
Apr 4, 2022
jaellio
approved these changes
Apr 4, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ x] I have cherry-picked any changes labelled
needs-cherry-pick-vX.Y.Z[ x] I have made all of the following version and patch updates:
[x ] I have checked that the base branch for this PR is correct as defined by the release guide
Is this a release candidate?