Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

feat(metrics): add conversion webhook metrics #4606

Merged
merged 1 commit into from
Mar 23, 2022
Merged

feat(metrics): add conversion webhook metrics #4606

merged 1 commit into from
Mar 23, 2022

Conversation

nojnhuh
Copy link
Contributor

@nojnhuh nojnhuh commented Mar 23, 2022

Description:
This change adds the osm_conversion_webhook_resource_total metric to
count custom resource conversions between API versions.

Part of #4568

Example:

osm_conversion_webhook_resource_total{from_version="config.openservicemesh.io/v1alpha1",kind="MeshConfig",success="true",to_version="config.openservicemesh.io/v1alpha2"} 1

Testing done:

  • Updated unit tests
  • Did some manual smoke testing with the whole control plane running and creating/updating/deleting a v1alpha1 MeshConfig

Affected area:

Functional Area
New Functionality [X]
CI System [ ]
CLI Tool [ ]
Certificate Management [ ]
Control Plane [ ]
Demo [ ]
Documentation [ ]
Egress [ ]
Ingress [ ]
Install [ ]
Networking [ ]
Observability [X]
Performance [ ]
SMI Policy [ ]
Security [ ]
Sidecar Injection [ ]
Tests [ ]
Upgrade [ ]
Other [ ]

Please answer the following questions with yes/no.

  1. Does this change contain code from or inspired by another project? No

    • Did you notify the maintainers and provide attribution?
  2. Is this a breaking change? No

  3. Has documentation corresponding to this change been updated in the osm-docs repo (if applicable)? Yes, add conversion webhook metric osm-docs#344

This change adds the `osm_conversion_webhook_resource_total` metric to
count custom resource conversions between API versions.

Part of #4568

Example:

    osm_conversion_webhook_resource_total{from_version="config.openservicemesh.io/v1alpha1",kind="MeshConfig",success="true",to_version="config.openservicemesh.io/v1alpha2"} 1

Signed-off-by: Jon Huhn <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Merging #4606 (0311eda) into main (aaa7f30) will increase coverage by 0.05%.
The diff coverage is 92.50%.

@@            Coverage Diff             @@
##             main    #4606      +/-   ##
==========================================
+ Coverage   69.14%   69.20%   +0.05%     
==========================================
  Files         216      216              
  Lines       15000    15028      +28     
==========================================
+ Hits        10372    10400      +28     
  Misses       4576     4576              
  Partials       52       52              
Flag Coverage Δ
unittests 69.20% <92.50%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/osm-bootstrap/osm-bootstrap.go 45.59% <0.00%> (-0.72%) ⬇️
pkg/crdconversion/crdconversion.go 75.53% <100.00%> (+0.72%) ⬆️
pkg/crdconversion/framework.go 74.56% <100.00%> (+6.88%) ⬆️
pkg/metricsstore/metricsstore.go 92.17% <100.00%> (+0.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aaa7f30...0311eda. Read the comment docs.

@trstringer trstringer merged commit 0f36516 into openservicemesh:main Mar 23, 2022
@nojnhuh nojnhuh deleted the conv-webhook-metrics branch March 29, 2022 16:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants