Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

owners: add @trstringer as a codeowner maintainer #4604

Merged
merged 1 commit into from
Mar 23, 2022

Conversation

shashankram
Copy link
Member

Description:
Adds @trstringer as a codeowner maintainer.

@trstringer has been contributing to the
day-to-day maintenance of this project,
documentation improvements, package upgrades
to address vulnerabilities, bug-reporting
enhancements, code reviews etc.

Maintainers, if you agree with this nomination,
leave a "+1" comment and approve the PR (do not
merge it).

Affected area:

Functional Area
Other [X]

Please answer the following questions with yes/no.

  1. Does this change contain code from or inspired by another project? no
    • Did you notify the maintainers and provide attribution?

Adds @trstringer as a codeowner maintainer.

@trstringer has been contributing to the
day-to-day maintenance of this project,
documentation improvements, package upgrades
to address vulnerabilities, bug-reporting
enhancements, code reviews etc.

**Maintainers**, if you agree with this nomination,
leave a "+1" comment and approve the PR (do not
merge it).

Signed-off-by: Shashank Ram <[email protected]>
Copy link
Contributor

@nojnhuh nojnhuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Contributor

@jaellio jaellio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@trstringer
Copy link
Contributor

Thank you for the nomination, @shashankram! I am honored, and I agree to all requirements of becoming a Maintainer.

@codecov-commenter
Copy link

Codecov Report

Merging #4604 (f65fc2b) into main (7e0674c) will decrease coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4604      +/-   ##
==========================================
- Coverage   68.85%   68.79%   -0.06%     
==========================================
  Files         217      217              
  Lines       15031    15031              
==========================================
- Hits        10349    10341       -8     
- Misses       4630     4638       +8     
  Partials       52       52              
Flag Coverage Δ
unittests 68.79% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/crdconversion/crdconversion.go 69.62% <0.00%> (-5.19%) ⬇️
pkg/ticker/ticker.go 83.33% <0.00%> (-3.85%) ⬇️
pkg/certificate/rotor/rotor.go 81.08% <0.00%> (-2.71%) ⬇️
pkg/messaging/workqueue.go 100.00% <0.00%> (+10.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e0674c...f65fc2b. Read the comment docs.

@shashankram
Copy link
Member Author

This is good to merge as a majority (3/5) of the existing maintainers are in agreement.

@shashankram shashankram merged commit 6bda5c3 into openservicemesh:main Mar 23, 2022
@shashankram shashankram deleted the add-maint branch March 23, 2022 16:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants