This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
feat(metrics): generalize admission webhook metrics #4597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds the `osm_admission_webhook_response_total` metric to
track all mutating and validating webhook responses by Kubernetes
resource kind and whether the request was successful or not.
Example:
osm_admission_webhook_response_total{kind="TrafficTarget",success="true"} 4
Part of #4568
Signed-off-by: Jon Huhn <[email protected]>
Signed-off-by: Jon Huhn <[email protected]>
nojnhuh
requested review from
shashankram,
snehachhabria,
draychev and
jaellio
as code owners
Signed-off-by: Jon Huhn <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #4597 +/- ##
==========================================
- Coverage 68.73% 68.69% -0.04%
==========================================
Files 217 216 -1
Lines 14954 14982 +28
==========================================
+ Hits 10278 10292 +14
- Misses 4624 4639 +15
+ Partials 52 51 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
jaellio
reviewed
Mar 17, 2022
| None | ||
| The following capabilities have been deprecated and cannot be used. | ||
|
|
||
| - The `osm_injector_injector_sidecar_count` and `osm_injector_injector_rq_time` metrics have been removed. The `osm_admission_webhook_response_total` and `osm_http_response_duration` metrics should be used instead. |
There was a problem hiding this comment.
With this change, the osm_injector_injector_rq_time and osm_injector_injector_sidecar_count metrics can be removed from the OSM Mesh and Envoy Details Grafana dashboard.
There was a problem hiding this comment.
I took a pass at editing the dashboards to use the new metrics instead of removing the dashboards completely.
Signed-off-by: Jon Huhn <[email protected]>
jaellio
approved these changes
Mar 21, 2022
shashankram
approved these changes
Mar 23, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This change adds the
osm_admission_webhook_response_totalmetric totrack all mutating and validating webhook responses by Kubernetes
resource kind and whether the request was successful or not.
Example:
Part of #4568
Testing done:
Affected area:
Please answer the following questions with yes/no.
Does this change contain code from or inspired by another project? No
Is this a breaking change? Yes, release notes updated
Has documentation corresponding to this change been updated in the osm-docs repo (if applicable)? Yes, add webhook metric osm-docs#341