This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
Allow custom image names for OSM Helm chart #4595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shalier
requested review from
shashankram,
snehachhabria,
nojnhuh,
draychev and
jaellio
as code owners
nojnhuh
approved these changes
Mar 16, 2022
Map image name in values.yaml and resolves openservicemesh#4331 Signed-off-by: Shalier Xia <[email protected]>
|
Should we allow the registry and tag to also be set per image? |
jaellio
approved these changes
Mar 16, 2022
I think eventually it's likely we'll end up making this possible, though I think exactly how we should do that needs some extra thought to consider things like how backwards-compatible it should be with the way it is now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Map image name in values.yaml and resolves #4331
Signed-off-by: Shalier Xia [email protected]
Testing done:
Affected area:
Please answer the following questions with yes/no.
Does this change contain code from or inspired by another project?
Is this a breaking change?
Has documentation corresponding to this change been updated in the osm-docs repo (if applicable)?