This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
fix(scripts): remove bash 4.0 dependency in coverage script #4561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`readarray` is a bash builtin introduced in 4.0. This change removes its use so `make go-test-coverage` can be run on Macs which only ship with bash 3.2 preinstalled. Fixes #2152 Signed-off-by: Jon Huhn <[email protected]>
nojnhuh
requested review from
shashankram,
snehachhabria,
draychev and
jaellio
as code owners
trstringer
approved these changes
Feb 28, 2022
jaellio
approved these changes
Feb 28, 2022
shashankram
approved these changes
Feb 28, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
readarrayis a bash builtin introduced in 4.0. This change removesits use so
make go-test-coveragecan be run on Macs which only shipwith bash 3.2 preinstalled.
Fixes #2152
Testing done:
Affected area:
Please answer the following questions with yes/no.
Does this change contain code from or inspired by another project? No
Is this a breaking change? No
Has documentation corresponding to this change been updated in the osm-docs repo (if applicable)? N/A