This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
apis: add UpstreamTrafficSetting API types #4535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shashankram
requested review from
snehachhabria,
nojnhuh,
draychev and
jaellio
as code owners
nojnhuh
reviewed
Feb 14, 2022
snehachhabria
approved these changes
Feb 14, 2022
jaellio
approved these changes
Feb 14, 2022
steeling
reviewed
Feb 14, 2022
steeling
reviewed
Feb 14, 2022
shashankram
force-pushed
the
upstream-api
branch
from
6a01f13 to
68f9e90
Compare
draychev
reviewed
Feb 15, 2022
| ) | ||
|
|
||
| // UpstreamTrafficSetting defines the settings applicable to traffic destined | ||
| // to an upstream host. |
There was a problem hiding this comment.
Examples being Circuit Breaking
draychev
approved these changes
Feb 15, 2022
There was a problem hiding this comment.
This is good stuff! Glad to see this being built out!
Thanks @shashankram !
shashankram
added
the
do-not-merge/hold
shashankram
force-pushed
the
upstream-api
branch
from
68f9e90 to
b949172
Compare
shashankram
removed
the
do-not-merge/hold
shashankram
changed the title
shashankram
force-pushed
the
upstream-api
branch
from
b949172 to
24d8fb5
Compare
Adds the Go types for UpstreamTrafficSetting API. *Note the defaults are not to be encoded in the JSON tags and will be implemented within the controller subsequently. Part of openservicemesh#4500 Signed-off-by: Shashank Ram <[email protected]>
shashankram
force-pushed
the
upstream-api
branch
from
24d8fb5 to
9c9ce65
Compare
schristoff
pushed a commit
to schristoff/osm
that referenced
this pull request
Feb 22, 2022
Adds the Go types for UpstreamTrafficSetting API. *Note the defaults are not to be encoded in the JSON tags and will be implemented within the controller subsequently. Part of openservicemesh#4500 Signed-off-by: Shashank Ram <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adds the Go types for UpstreamTrafficSetting API.
*Note the defaults are not to be encoded in
the JSON tags and will be implemented within
the controller subsequently.
Part of #4500
Affected area:
Please answer the following questions with yes/no.
Does this change contain code from or inspired by another project?
noIs this a breaking change?
no