Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

chore(cleanup): remove cleanup script #4506

Merged
merged 1 commit into from
Feb 3, 2022

Conversation

SanyaKochhar
Copy link
Contributor

@SanyaKochhar SanyaKochhar commented Feb 3, 2022

Signed-off-by: Sanya Kochhar [email protected]

Description:
Deletes the cleanup script as this is no longer used and is documented as user-facing steps here: openservicemesh/osm-docs#254

Testing done:

Affected area:
| Documentation | [x] |

Reopen of #4302

Please answer the following questions with yes/no.

  1. Does this change contain code from or inspired by another project?
    • Did you notify the maintainers and provide attribution?
      no
  2. Is this a breaking change?
    no

Copy link
Member

@shashankram shashankram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SanyaKochhar Could you drop the update to the release guide and only have this PR remove the cleanup script? I'd like to avoid unnecessary overhead in the release workflow.

docs/release_guide.md Outdated Show resolved Hide resolved
docs/release_guide.md Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Feb 3, 2022

Codecov Report

Merging #4506 (3c5fc00) into main (3367f49) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 3c5fc00 differs from pull request most recent head 17d6ade. Consider uploading reports for the commit 17d6ade to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4506   +/-   ##
=======================================
  Coverage   69.25%   69.25%           
=======================================
  Files         213      213           
  Lines       14625    14627    +2     
=======================================
+ Hits        10128    10130    +2     
  Misses       4446     4446           
  Partials       51       51           
Flag Coverage Δ
unittests 69.25% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/injector/init_container.go 100.00% <0.00%> (ø)
pkg/injector/webhook.go 88.30% <0.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3367f49...17d6ade. Read the comment docs.

@nojnhuh nojnhuh dismissed shashankram’s stale review February 3, 2022 21:55

Changes have been addressed

Deletes the cleanup script as this is no longer used and is documented as user-facing steps in osm-docs/pull/254

Signed-off-by: Sanya Kochhar <[email protected]>
@shashankram shashankram merged commit 0986001 into openservicemesh:main Feb 3, 2022
@SanyaKochhar SanyaKochhar deleted the uninstall-cleanup branch February 3, 2022 22:22
schristoff pushed a commit to schristoff/osm that referenced this pull request Feb 22, 2022
Deletes the cleanup script as this is no longer used and is 
documented as user-facing steps in osm-docs/pull/254

Signed-off-by: Sanya Kochhar <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants