This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
crdconversion: handle MeshConfig optional field #4497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handles the conversion of the optional field in v1alpha2 and adds a test for conversion between v1alpha1 and v1alpha2 of MeshConfig. Signed-off-by: Shashank Ram <[email protected]>
shashankram
requested review from
draychev,
jaellio,
nojnhuh and
snehachhabria
as code owners
snehachhabria
approved these changes
Feb 1, 2022
nojnhuh
approved these changes
Feb 1, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Handles the conversion of the optional field in
v1alpha2 and adds a test for conversion between
v1alpha1 and v1alpha2 of MeshConfig.
Testing done:
Unit tests
Affected area:
Please answer the following questions with yes/no.
Does this change contain code from or inspired by another project?
noIs this a breaking change?
no