Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

tests: remove kubectl dependency for namespace info #4485

Merged
merged 1 commit into from
Jan 26, 2022

Conversation

shashankram
Copy link
Member

Description:
Removes the dependency on kubectl to dump the namespace
info. Previously this was done to unblock debugging
of CI failures in a timely manner.

Affected area:

Functional Area
Tests [X]

Please answer the following questions with yes/no.

  1. Does this change contain code from or inspired by another project? no

    • Did you notify the maintainers and provide attribution?
  2. Is this a breaking change? no

Removes the dependency on kubectl to dump the namespace
info. Previously this was done to unblock debugging
of CI failures in a timely manner.

Signed-off-by: Shashank Ram <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Merging #4485 (0eba3c3) into main (d95ebc9) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4485   +/-   ##
=======================================
  Coverage   69.17%   69.18%           
=======================================
  Files         212      213    +1     
  Lines       14568    14559    -9     
=======================================
- Hits        10078    10072    -6     
+ Misses       4438     4435    -3     
  Partials       52       52           
Flag Coverage Δ
unittests 69.18% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/injector/patch.go 88.46% <0.00%> (-1.37%) ⬇️
pkg/injector/webhook.go 88.26% <0.00%> (-0.87%) ⬇️
pkg/injector/exclusions.go 100.00% <0.00%> (ø)
pkg/messaging/workqueue.go 100.00% <0.00%> (+10.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d95ebc9...0eba3c3. Read the comment docs.

@shashankram shashankram merged commit 3849554 into openservicemesh:main Jan 26, 2022
@shashankram shashankram deleted the e2e-log branch January 26, 2022 20:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants