This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
tests/framework: wait for deletion and dump namespace #4471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Waits for resources created by Helm to delete prior to performing deletion of the entire namespace. Without this, some dangling resources can be left behind in the cluster such and the namespace could be stuck in the terminating state. Also dumps the namespaces that fail to terminate. This is necessary to root cause namespace deletion issues. Signed-off-by: Shashank Ram <[email protected]>
shashankram
requested review from
draychev,
jaellio,
nojnhuh and
snehachhabria
as code owners
snehachhabria
approved these changes
Jan 24, 2022
nojnhuh
reviewed
Jan 24, 2022
Comment on lines
+1245
to
+1249
| // Dump the namespaces that failed to terminate | ||
| stdout, stderr, _ := td.RunLocal("kubectl", "get", "namespace", "-l", osmTest, "-o", "yaml") | ||
| td.T.Logf("Namespace info:") | ||
| td.T.Logf("stdout:\n%s", stdout) | ||
| td.T.Logf("stderr:\n%s", stderr) |
There was a problem hiding this comment.
For something this simple, could you use the k8s Go client instead to do this? There are only a couple places we invoke kubectl directly and I'd rather not add more if we can help it.
There was a problem hiding this comment.
I'd rather not, in the interest of simplifying how the object is dumped nicely by kubectl.
Signed-off-by: Shashank Ram <[email protected]>
jaellio
approved these changes
Jan 24, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Waits for resources created by Helm to delete prior
to performing deletion of the entire namespace.
Without this, some dangling resources can be left
behind in the cluster such and the namespace could
be stuck in the terminating state.
Also dumps the namespaces that fail to terminate. This
is necessary to root cause namespace deletion issues.
Testing done:
Used this change to root cause a bug in uninstall that left
namespaces in a dangling state.
Affected area:
Please answer the following questions with yes/no.
Does this change contain code from or inspired by another project?
noIs this a breaking change?
no