Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

docs: remove demo manifests required by website #4455

Merged
merged 1 commit into from
Jan 14, 2022

Conversation

shashankram
Copy link
Member

Description:
Removes the demo manifests required by the docs
website as these have been moved to the osm-docs
repo.

Affected area:

Functional Area
Other [X]

Please answer the following questions with yes/no.

  1. Does this change contain code from or inspired by another project? no

    • Did you notify the maintainers and provide attribution?
  2. Is this a breaking change? no

@codecov-commenter
Copy link

codecov-commenter commented Jan 14, 2022

Codecov Report

Merging #4455 (172f181) into main (bfc256d) will decrease coverage by 0.17%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4455      +/-   ##
==========================================
- Coverage   69.21%   69.03%   -0.18%     
==========================================
  Files         212      212              
  Lines       14580    14580              
==========================================
- Hits        10091    10065      -26     
- Misses       4437     4463      +26     
  Partials       52       52              
Flag Coverage Δ
unittests 69.03% <ø> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/crdconversion/crdconversion.go 57.46% <0.00%> (-17.17%) ⬇️
pkg/ticker/ticker.go 83.33% <0.00%> (-3.85%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfc256d...172f181. Read the comment docs.

@jaellio
Copy link
Contributor

jaellio commented Jan 14, 2022

In release_pull_request_template.md can the check "Updated the image tags used in the demo manifests" be removed?

Removes the demo manifests required by the docs
website as these have been moved to the osm-docs
repo.

Signed-off-by: Shashank Ram <[email protected]>
@shashankram
Copy link
Member Author

In release_pull_request_template.md can the check "Updated the image tags used in the demo manifests" be removed?

The words demo manifests here can be a bit misleading, where it could be referring to the automated demo manifests inlined in the bash scripts. I rephrased this.

@shashankram shashankram merged commit 2da6870 into openservicemesh:main Jan 14, 2022
@shashankram shashankram deleted the manifests branch January 14, 2022 23:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants