This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
fix(grafana): remove hardcoded control plane namespace #4454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes the hardcoded default control plane namespace from the Mesh and Envoy Details dashboard. Parameterizes the control plane namespace. When installing OSM with automatic provisioning of prometheus and grafana the control plane namespace variable will be set to the namespace where OSM is being installed. When importing the Mesh and Envoy Details dashboard, the user will have the option to set the osm control plane namespace just as they are able to set the datasource. Signed-off-by: jaellio <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #4454 +/- ##
==========================================
+ Coverage 69.14% 69.21% +0.06%
==========================================
Files 212 212
Lines 14580 14580
==========================================
+ Hits 10082 10092 +10
+ Misses 4446 4436 -10
Partials 52 52
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
jaellio
requested review from
draychev,
nojnhuh,
shashankram and
snehachhabria
as code owners
snehachhabria
approved these changes
Jan 14, 2022
jaellio
added a commit
to jaellio/osm
that referenced
this pull request
Jan 18, 2022
…sh#4454) Removes the hardcoded default control plane namespace from the Mesh and Envoy Details dashboard. Parameterizes the control plane namespace. When installing OSM with automatic provisioning of prometheus and grafana the control plane namespace variable will be set to the namespace where OSM is being installed. When importing the Mesh and Envoy Details dashboard, the user will have the option to set the osm control plane namespace just as they are able to set the datasource. Signed-off-by: jaellio <[email protected]>
jaellio
added a commit
to jaellio/osm
that referenced
this pull request
Jan 19, 2022
…sh#4454) Removes the hardcoded default control plane namespace from the Mesh and Envoy Details dashboard. Parameterizes the control plane namespace. When installing OSM with automatic provisioning of prometheus and grafana the control plane namespace variable will be set to the namespace where OSM is being installed. When importing the Mesh and Envoy Details dashboard, the user will have the option to set the osm control plane namespace just as they are able to set the datasource. Signed-off-by: jaellio <[email protected]>
jaellio
added a commit
that referenced
this pull request
Jan 19, 2022
Removes the hardcoded default control plane namespace from the Mesh and Envoy Details dashboard. Parameterizes the control plane namespace. When installing OSM with automatic provisioning of prometheus and grafana the control plane namespace variable will be set to the namespace where OSM is being installed. When importing the Mesh and Envoy Details dashboard, the user will have the option to set the osm control plane namespace just as they are able to set the datasource. Signed-off-by: jaellio <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Removes the hardcoded default control plane namespace from the
Mesh and Envoy Details dashboard. Parameterizes the control plane
namespace. When installing OSM with automatic provisioning of
Prometheus and Grafana the control plane namespace variable will
be set to the namespace where OSM is being installed. When
importing the Mesh and Envoy Details dashboard, the user will have
the option to set the osm control plane namespace just as they are
able to set the datasource.
Resolves #4436
View when importing the Mesh and Envoy Details dashboard:
Testing done:
Affected area:
Please answer the following questions with yes/no.
Does this change contain code from or inspired by another project? No
Is this a breaking change? No