This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
[reconciler]: fix label assignment on mwhc #4431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed label assignment on the mwhc by reusing the locally created labels for correct assignment of reconciler labels. Signed-off-by: Sneha Chhabria <[email protected]>
snehachhabria
requested review from
draychev,
jaellio,
nojnhuh and
shashankram
as code owners
shashankram
approved these changes
Jan 12, 2022
nojnhuh
approved these changes
Jan 12, 2022
This change was added to ensure the presence of the label is consistent with the docs. when the reconciler isn't enabled, there shouldn't be a reconcile label on the resources. We won't really need a unit test for this as it doesn't impact functionality |
|
@Mergifyio backport release-v1.0 |
mergify bot
pushed a commit
that referenced
this pull request
Jan 12, 2022
Fixed label assignment on the mwhc by reusing the locally created labels for correct assignment of reconciler labels. Signed-off-by: Sneha Chhabria <[email protected]> (cherry picked from commit c7675e5)
✅ Backports have been created
|
snehachhabria
added a commit
that referenced
this pull request
Jan 12, 2022
Fixed label assignment on the mwhc by reusing the locally created labels for correct assignment of reconciler labels. Signed-off-by: Sneha Chhabria <[email protected]> (cherry picked from commit c7675e5) Co-authored-by: Sneha Chhabria <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixed label assignment on the mwhc by reusing the locally created labels
for correct assignment of reconciler labels.
Signed-off-by: Sneha Chhabria [email protected]
Testing done: Manually verified the change
Affected area:
Please answer the following questions with yes/no.
Does this change contain code from or inspired by another project?
noIs this a breaking change?
no