This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
chore(route): Refactor buildRoute() by reducing parameters #4407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shalier
requested review from
draychev,
eduser25,
nojnhuh,
shashankram and
snehachhabria
as code owners
shashankram
reviewed
Dec 27, 2021
shalier
force-pushed
the
refactorBuildRoute
branch
from
5656d83 to
3816231
Compare
shashankram
reviewed
Dec 28, 2021
Refactored buildRoute() to take in a RouteWeightedClusters struct also fixed a typo in scale test and resolves openservicemesh#4020 Signed-off-by: Shalier Xia <[email protected]>
shalier
force-pushed
the
refactorBuildRoute
branch
from
3816231 to
fae9888
Compare
shashankram
approved these changes
Jan 5, 2022
draychev
approved these changes
Jan 5, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Refactored buildRoute() to take in a RouteWeightedClusters struct
also fixed a typo in scale test and resolves #4020
Signed-off-by: Shalier Xia [email protected]
Testing done:
Re-wrote unit test for buildRoute()
Affected area:
Please answer the following questions with yes/no.
Does this change contain code from or inspired by another project? no
Is this a breaking change? no