This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
injector: rename iptables chains for clarity #4379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renames the iptables chains and prefixes the custom chains with `OSM_` to indicate these chains are owned by OSM. It renames the custom chains as follows: PROXY_INBOUND -> OSM_PROXY_INBOUND PROXY_OUTPUT -> OSM_PROXY_OUTBOUND PROXY_IN_REDIRECT -> OSM_PROXY_IN_REDIRECT PROXY_REDIRECT -> OSM_PROXY_OUT_REDIRECT Signed-off-by: Shashank Ram <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #4379 +/- ##
==========================================
+ Coverage 69.21% 69.29% +0.07%
==========================================
Files 212 212
Lines 14450 14455 +5
==========================================
+ Hits 10002 10016 +14
+ Misses 4396 4387 -9
Partials 52 52
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
shashankram
requested review from
draychev,
eduser25,
michelleN,
nojnhuh and
snehachhabria
as code owners
nojnhuh
approved these changes
Dec 1, 2021
michelleN
approved these changes
Dec 2, 2021
jaellio
approved these changes
Dec 2, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Renames the iptables chains and prefixes the
custom chains with
OSM_to indicate thesechains are owned by OSM.
It renames the custom chains as follows:
PROXY_INBOUND -> OSM_PROXY_INBOUND
PROXY_OUTPUT -> OSM_PROXY_OUTBOUND
PROXY_IN_REDIRECT -> OSM_PROXY_IN_REDIRECT
PROXY_REDIRECT -> OSM_PROXY_OUT_REDIRECT
Testing done:
Affected area:
Please answer the following questions with yes/no.
Does this change contain code from or inspired by another project?
noIs this a breaking change?
no