Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

[backport] fix(ci): fix image scan #4363

Merged
merged 1 commit into from
Nov 16, 2021
Merged

[backport] fix(ci): fix image scan #4363

merged 1 commit into from
Nov 16, 2021

Conversation

nojnhuh
Copy link
Contributor

@nojnhuh nojnhuh commented Nov 15, 2021

Description: Backport of #4357

This change adds the version job as a dependency of the imagescan
job in the pre-release workflow which is required for
${{ needs.version.outputs.version }} to correctly evaluate.

The base image of the init container has also been updated to fix a
vulnerability.

Affected area:

Functional Area
New Functionality [ ]
CI System [X]
CLI Tool [ ]
Certificate Management [ ]
Control Plane [ ]
Demo [ ]
Documentation [ ]
Egress [ ]
Ingress [ ]
Install [ ]
Networking [ ]
Observability [ ]
Performance [ ]
SMI Policy [ ]
Security [ ]
Sidecar Injection [ ]
Tests [ ]
Upgrade [ ]
Other [ ]

Please answer the following questions with yes/no.

  1. Does this change contain code from or inspired by another project? No

    • Did you notify the maintainers and provide attribution?
  2. Is this a breaking change? No

This change adds the `version` job as a dependency of the `imagescan`
job in the pre-release workflow which is required for
`${{ needs.version.outputs.version }}` to correctly evaluate.

The base image of the `init` container has also been updated to fix a
vulnerability.

Signed-off-by: Jon Huhn <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Merging #4363 (4cf9687) into main (0fcedaa) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4363   +/-   ##
=======================================
  Coverage   69.18%   69.18%           
=======================================
  Files         212      212           
  Lines       14458    14458           
=======================================
  Hits        10003    10003           
  Misses       4403     4403           
  Partials       52       52           
Flag Coverage Δ
unittests 69.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0fcedaa...4cf9687. Read the comment docs.

@nojnhuh nojnhuh merged commit e5b2754 into openservicemesh:main Nov 16, 2021
@nojnhuh nojnhuh deleted the fix-image-scan branch November 16, 2021 18:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants