This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
Typo fix for dev guide README #4347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bridget Kromhout <[email protected]>
bridgetkromhout
requested review from
draychev,
eduser25,
michelleN,
nojnhuh,
shashankram and
snehachhabria
as code owners
nojnhuh
reviewed
Nov 9, 2021
draychev
approved these changes
Nov 9, 2021
There was a problem hiding this comment.
@bridgetkromhout I took the liberty to merge @nojnhuh's suggestion into this PR.
Coverage is always great to have (though it does run a bit slower than tests without coverage)
Thanks for the fix!
nojnhuh
approved these changes
Nov 9, 2021
|
@bridgetkromhout could you please squash Delyan's commit into your original one so the DCO check passes? I think I can do that on your behalf but would want to make sure that's ok with you before I do. |
Co-authored-by: Jon Huhn <[email protected]> Signed-off-by: Jon Huhn <[email protected]>
Actually since that's my/Delyan's commit I went ahead and signed it off. Merging this. |
allenlsy
pushed a commit
to allenlsy/osm
that referenced
this pull request
Dec 28, 2021
* Typo fix Signed-off-by: Bridget Kromhout <[email protected]> * Update docs/development_guide/README.md Co-authored-by: Jon Huhn <[email protected]> Signed-off-by: Jon Huhn <[email protected]> Co-authored-by: Delyan Raychev <[email protected]> Co-authored-by: Jon Huhn <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4281
Signed-off-by: Bridget Kromhout [email protected]
Description:
As @clarenceb points out in #4281, we have a typo in the dev guide README.
Affected area:
Please answer the following questions with yes/no.
Does this change contain code from or inspired by another project? no
Is this a breaking change? no