This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
tests/e2e: skip traffic split selector test for OpenShift #4320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The traffic split selector tests uses default service accounts and doesn't need to be tested on OpenShift. The security context constraints would need to be applied for this test to work on OpenShift, while the test itself is primarily testing the label selector logic in the control plane. Signed-off-by: Shashank Ram <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #4320 +/- ##
=======================================
Coverage 69.16% 69.16%
=======================================
Files 211 211
Lines 14251 14251
=======================================
Hits 9856 9856
Misses 4347 4347
Partials 48 48
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
snehachhabria
approved these changes
Oct 28, 2021
nojnhuh
approved these changes
Oct 28, 2021
allenlsy
pushed a commit
to allenlsy/osm
that referenced
this pull request
Dec 28, 2021
…emesh#4320) The traffic split selector tests uses default service accounts and doesn't need to be tested on OpenShift. The security context constraints would need to be applied for this test to work on OpenShift, while the test itself is primarily testing the label selector logic in the control plane. Signed-off-by: Shashank Ram <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The traffic split selector test uses default service accounts
and doesn't need to be tested on OpenShift. The security
context constraints would need to be applied for this test
to work on OpenShift, while the test itself is primarily
testing the label selector logic in the control plane.
Affected area:
Please answer the following questions with yes/no.
Does this change contain code from or inspired by another project?
noIs this a breaking change?
no