Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

chore(grafana): update Grafana version #4318

Merged
merged 1 commit into from
Oct 28, 2021

Conversation

jaellio
Copy link
Contributor

@jaellio jaellio commented Oct 27, 2021

Description:

Updates image versions for grafana and grafana image renderer. The
version of grafana that osm currently uses is not supported by
Grafana Labs. Therefore, osm cannot share dashboards in the grafana
dashboard library.

Updates outdated graph type to timeseries.

Part of #4282

Testing done

Installed osm with Prometheus and Grafana enabled. The Grafana instance behaved as
expected and the time-series graphs were rendered correctly.

Affected area:

Functional Area
New Functionality [ ]
CI System [ ]
CLI Tool [ ]
Certificate Management [ ]
Control Plane [ ]
Demo [ ]
Documentation [ ]
Egress [ ]
Ingress [ ]
Install [ ]
Networking [ ]
Observability [ x ]
Performance [ ]
SMI Policy [ ]
Security [ ]
Sidecar Injection [ ]
Tests [ ]
Upgrade [ ]
Other [ ]

Please answer the following questions with yes/no.

  1. Does this change contain code from or inspired by another project? No

    • Did you notify the maintainers and provide attribution?
  2. Is this a breaking change? No

@jaellio jaellio force-pushed the updateGrafanaVersion branch from eacd843 to 69397b4 Compare October 27, 2021 17:31
@jaellio jaellio changed the title Update grafana version chore(grafana): update Grafana version Oct 27, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #4318 (69397b4) into main (30a2f05) will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4318      +/-   ##
==========================================
- Coverage   69.16%   69.11%   -0.05%     
==========================================
  Files         211      211              
  Lines       14251    14251              
==========================================
- Hits         9856     9849       -7     
- Misses       4347     4354       +7     
  Partials       48       48              
Flag Coverage Δ
unittests 69.11% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/crdconversion/crdconversion.go 69.92% <0.00%> (-4.52%) ⬇️
pkg/certificate/rotor/rotor.go 84.78% <0.00%> (-2.18%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30a2f05...69397b4. Read the comment docs.

@jaellio jaellio marked this pull request as ready for review October 27, 2021 17:56
@jaellio jaellio requested a review from a team as a code owner October 27, 2021 17:56
@jaellio jaellio marked this pull request as draft October 27, 2021 17:57
@jaellio jaellio force-pushed the updateGrafanaVersion branch from 69397b4 to 466c45c Compare October 27, 2021 18:06
@jaellio jaellio marked this pull request as ready for review October 27, 2021 18:07
Copy link
Contributor

@nojnhuh nojnhuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried this out and everything looks good to me.

Copy link
Contributor

@eduser25 eduser25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much needed; newer versions were required to load emojivoto k8s benchmark dashboards

Updates image versions for grafana and grafana image renderer. The
version of grafana that osm currently uses is not supported by
Grafana lab. Therefore, osm cannot share dashboards in the grafana
dashboard library.

Updates outdated graph type to timeseries.

Signed-off-by: jaellio <[email protected]>
@jaellio jaellio force-pushed the updateGrafanaVersion branch from 466c45c to 675f2e2 Compare October 28, 2021 18:03
@jaellio jaellio merged commit 5d5e0a8 into openservicemesh:main Oct 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants