ref(charts) update top OpenServiceMesh key to osm

[michelleN]

Signed-off-by: Michelle Noorali [email protected]

Description:
This PR updates the top level OpenServiceMesh key to osm and resolves #4164. Initially as part of #4164 we wanted to remove the top level key altogether but because of the way the images are defined and contained and because there are values for other child charts in this values file, keeping a top level key helps with organization and readability. It also makes the config passed in through the --set flag easier to understand because the top level key provides clarity in scoping.

Testing done:

Affected area:

Functional Area
New Functionality	[ ]
CI System	[ ]
CLI Tool	[ ]
Certificate Management	[ ]
Control Plane	[ ]
Demo	[ X]
Documentation	[X ]
Egress	[ ]
Ingress	[ ]
Install	[ X]
Networking	[ ]
Observability	[ ]
Performance	[ ]
SMI Policy	[ ]
Security	[ ]
Sidecar Injection	[ ]
Tests	[X ]
Upgrade	[ ]
Other	[ ]

Please answer the following questions with yes/no.

1. Does this change contain code from or inspired by another project? No

   • Did you notify the maintainers and provide attribution? NA

2. Is this a breaking change? Yes

[codecov-commenter]

Codecov Report

Merging #4317 (a01bd33) into main (30a2f05) will not change coverage.
The diff coverage is 71.42%.

@@           Coverage Diff           @@
##             main    #4317   +/-   ##
=======================================
  Coverage   69.16%   69.16%           
=======================================
  Files         211      211           
  Lines       14251    14251           
=======================================
  Hits         9856     9856           
  Misses       4347     4347           
  Partials       48       48           

Flag	Coverage Δ
unittests	69.16% <71.42%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
cmd/cli/install.go	76.33% <66.66%> (ø)
cmd/cli/mesh_upgrade.go	72.05% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30a2f05...a01bd33. Read the comment docs.

[shashankram]

Thanks @michelleN. I created openservicemesh/osm-docs#263 to track the changed required in osm-docs.