This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
fix(preset-mesh-config.yaml): add json check #4241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ adds mustToJson function to values in json blob to ensure value can be converted to proper json. Returns error if not. + If value is passed in via --set, user doesn't need to worry about passing in proper json Resolves openservicemesh#4239 Signed-off-by: Michelle Noorali <[email protected]>
shashankram
approved these changes
Oct 12, 2021
trstringer
approved these changes
Oct 12, 2021
snehachhabria
approved these changes
Oct 12, 2021
snehachhabria
pushed a commit
to snehachhabria/osm
that referenced
this pull request
Oct 14, 2021
+ adds mustToJson function to values in json blob to ensure value can be converted to proper json. Returns error if not. + If value is passed in via --set, user doesn't need to worry about passing in proper json Resolves openservicemesh#4239 Signed-off-by: Michelle Noorali <[email protected]> Signed-off-by: Sneha Chhabria <[email protected]>
allenlsy
pushed a commit
to allenlsy/osm
that referenced
this pull request
Dec 28, 2021
+ adds mustToJson function to values in json blob to ensure value can be converted to proper json. Returns error if not. + If value is passed in via --set, user doesn't need to worry about passing in proper json Resolves openservicemesh#4239 Signed-off-by: Michelle Noorali <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to ensure value can be converted to proper json. Returns
error if not.
to worry about passing in proper json
Resolves #4239
Signed-off-by: Michelle Noorali [email protected]
Description:
Testing done:
Affected area:
Please answer the following questions with yes/no.
Does this change contain code from or inspired by another project?
Is this a breaking change?