This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
fix(cli): fix uninstall cmd not showing smi info #4235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Johnson Shi <[email protected]>
johnsonshi
force-pushed
the
osm-uninstall-missing-smi-info
branch
from
7fce016 to
9295f60
Compare
Codecov Report
@@ Coverage Diff @@
## main #4235 +/- ##
==========================================
- Coverage 69.57% 69.57% -0.01%
==========================================
Files 211 211
Lines 11436 11438 +2
==========================================
+ Hits 7957 7958 +1
- Misses 3430 3431 +1
Partials 49 49
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
allenlsy
reviewed
Oct 8, 2021
| f.BoolVar(&uninstall.deleteNamespace, "delete-namespace", false, "Attempt to delete the namespace after control plane components are deleted") | ||
| f.Uint16VarP(&uninstall.localPort, "local-port", "p", constants.OSMHTTPServerPort, "Local port to use for port forwarding") |
There was a problem hiding this comment.
Suggest adding "Default is 9091" to the description
allenlsy
approved these changes
Oct 8, 2021
nshankar13
approved these changes
Oct 12, 2021
allenlsy
pushed a commit
to allenlsy/osm
that referenced
this pull request
Dec 28, 2021
Signed-off-by: Johnson Shi <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The osm uninstall (osm delete) command prints out a list of
osm meshes before prompting the user for action. The column
for supported SMI versions in the uninstall prompt shows
"Unknown" because the
localPortargument (requiredfor port-forwarding to obtain SMI info) is missing.
Resolves #4195
Signed-off-by: Johnson Shi [email protected]
Description:
Testing done:
Affected area:
Please answer the following questions with yes/no.
Does this change contain code from or inspired by another project? N
Is this a breaking change? N