Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

metrics: add counters related to proxy response send #4219

Merged
merged 1 commit into from
Oct 6, 2021

Conversation

shashankram
Copy link
Member

Description:
Adds metrics counters for successful and failed sends
to proxies.

Resolves #4191

Testing done:

# HELP osm_proxy_response_send_error_count Represents the number of responses that errored when being set to proxies
# TYPE osm_proxy_response_send_error_count counter
osm_proxy_response_send_error_count 0
# HELP osm_proxy_response_send_success_count Represents the number of responses successfully sent to proxies
# TYPE osm_proxy_response_send_success_count counter
osm_proxy_response_send_success_count 555

Affected area:

Functional Area
Observability [X]

Please answer the following questions with yes/no.

  1. Does this change contain code from or inspired by another project? no

    • Did you notify the maintainers and provide attribution?
  2. Is this a breaking change? no

Adds metrics counters for successful and failed sends
to proxies.

Resolves openservicemesh#4191

Signed-off-by: Shashank Ram <[email protected]>
@shashankram shashankram requested a review from a team as a code owner October 6, 2021 17:52
@shashankram shashankram merged commit 0e3f746 into openservicemesh:main Oct 6, 2021
@shashankram shashankram deleted the metrics branch October 6, 2021 19:21
snehachhabria pushed a commit to snehachhabria/osm that referenced this pull request Oct 14, 2021
…#4219)

Adds metrics counters for successful and failed sends
to proxies.

Resolves openservicemesh#4191

Signed-off-by: Shashank Ram <[email protected]>
Signed-off-by: Sneha Chhabria <[email protected]>
allenlsy pushed a commit to allenlsy/osm that referenced this pull request Dec 28, 2021
…#4219)

Adds metrics counters for successful and failed sends
to proxies.

Resolves openservicemesh#4191

Signed-off-by: Shashank Ram <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a new prom counter for the number of XDS sends from OSM Controller to Envoys
3 participants