Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

feat(hpa): Adds memory targetAverageUtilization #4217

Merged
merged 1 commit into from
Nov 8, 2021

Conversation

shalier
Copy link
Contributor

@shalier shalier commented Oct 6, 2021

Description:
Allows HPA to react to memory utilization(not only CPU)

Signed-off-by: Shalier Xia [email protected]

Testing done:

Affected area:

Functional Area
New Functionality [x ]

Please answer the following questions with yes/no.

  1. Does this change contain code from or inspired by another project?no

    • Did you notify the maintainers and provide attribution?
  2. Is this a breaking change?no

@shalier shalier requested a review from a team as a code owner October 6, 2021 16:38
charts/osm/values.yaml Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Merging #4217 (9118bfa) into main (0309a0f) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 9118bfa differs from pull request most recent head b2f8f27. Consider uploading reports for the commit b2f8f27 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4217      +/-   ##
==========================================
- Coverage   69.58%   69.57%   -0.01%     
==========================================
  Files         211      211              
  Lines       11424    11424              
==========================================
- Hits         7949     7948       -1     
- Misses       3426     3427       +1     
  Partials       49       49              
Flag Coverage Δ
unittests 69.57% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/messaging/workqueue.go 89.47% <0.00%> (-10.53%) ⬇️
pkg/certificate/rotor/rotor.go 87.50% <0.00%> (+3.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0309a0f...b2f8f27. Read the comment docs.

Allows HPA to react to memory utilization(not only CPU)

Signed-off-by: Shalier Xia <[email protected]>
Copy link
Contributor

@draychev draychev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!
Thank you @shalier

@draychev draychev merged commit 701d1c3 into openservicemesh:main Nov 8, 2021
allenlsy pushed a commit to allenlsy/osm that referenced this pull request Dec 28, 2021
Allows HPA to react to memory utilization(not only CPU)

Signed-off-by: Shalier Xia <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants