This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
envoy/registry: do not track disconnected proxies #4216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Proxies are expected to disconnect when the corresponding pods are recycled. Since the cluster can go through a lot of churn, keeping track of disconnected proxies results in additional memory consumption and bookkeeping which is better avoided. It is easy enough to know how many times a proxy has reconnected to a control plane after a disconnect using the osm_proxy_reconnect_count metric. Signed-off-by: Shashank Ram <[email protected]>
shashankram
force-pushed
the
proxy-unreg
branch
from
20e2327 to
2d9dc11
Compare
Codecov Report
@@ Coverage Diff @@
## main #4216 +/- ##
==========================================
- Coverage 69.58% 69.55% -0.03%
==========================================
Files 211 211
Lines 11424 11411 -13
==========================================
- Hits 7949 7937 -12
+ Misses 3426 3425 -1
Partials 49 49
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
snehachhabria
approved these changes
Oct 6, 2021
allenlsy
approved these changes
Oct 6, 2021
snehachhabria
pushed a commit
to snehachhabria/osm
that referenced
this pull request
Oct 14, 2021
Proxies are expected to disconnect when the corresponding pods are recycled. Since the cluster can go through a lot of churn, keeping track of disconnected proxies results in additional memory consumption and bookkeeping which is better avoided. It is easy enough to know how many times a proxy has reconnected to a control plane after a disconnect using the osm_proxy_reconnect_count metric. Signed-off-by: Shashank Ram <[email protected]> Signed-off-by: Sneha Chhabria <[email protected]>
allenlsy
pushed a commit
to allenlsy/osm
that referenced
this pull request
Dec 28, 2021
Proxies are expected to disconnect when the corresponding pods are recycled. Since the cluster can go through a lot of churn, keeping track of disconnected proxies results in additional memory consumption and bookkeeping which is better avoided. It is easy enough to know how many times a proxy has reconnected to a control plane after a disconnect using the osm_proxy_reconnect_count metric. Signed-off-by: Shashank Ram <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Proxies are expected to disconnect when the corresponding
pods are recycled.
Since the cluster can go through a lot of churn, keeping
track of disconnected proxies results in additional
memory consumption and bookkeeping which is better avoided.
It is easy enough to know how many times a proxy has
reconnected to a control plane after a disconnect using
the osm_proxy_reconnect_count metric.
Affected area:
Please answer the following questions with yes/no.
Does this change contain code from or inspired by another project?
noIs this a breaking change?
no