Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

revert(psp): Remove PSP code for 1.0.0 #4163

Merged
merged 1 commit into from
Sep 27, 2021
Merged

Conversation

ksubrmnn
Copy link
Contributor

Signed-off-by: Kalya Subramanian [email protected]

Description:
Removes PSP code.

PSP was deprecated in OSM in 0.10.0 with removal scheduled for 1.0.0

Fixes #4122

Testing done:

Affected area:

Functional Area
New Functionality [ ]
CI System [ ]
CLI Tool [ ]
Certificate Management [ ]
Control Plane [ ]
Demo [ ]
Documentation [ ]
Egress [ ]
Ingress [ ]
Install [X]
Networking [ ]
Observability [ ]
Performance [ ]
SMI Policy [ ]
Security [ ]
Sidecar Injection [ ]
Tests [ ]
Upgrade [ ]
Other [ ]

Please answer the following questions with yes/no.

  1. Does this change contain code from or inspired by another project?
    • Did you notify the maintainers and provide attribution?
      No
  2. Is this a breaking change?
    No

@ksubrmnn ksubrmnn marked this pull request as ready for review September 23, 2021 19:28
@ksubrmnn ksubrmnn requested a review from a team as a code owner September 23, 2021 19:28
charts/osm/templates/osm-bootstrap-deployment.yaml Outdated Show resolved Hide resolved
charts/osm/templates/osm-injector-deployment.yaml Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Merging #4163 (f10badc) into main (92c7760) will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4163      +/-   ##
==========================================
+ Coverage   69.79%   69.86%   +0.07%     
==========================================
  Files         211      212       +1     
  Lines       11463    11583     +120     
==========================================
+ Hits         8001     8093      +92     
- Misses       3409     3437      +28     
  Partials       53       53              
Flag Coverage Δ
unittests 69.86% <ø> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/reconciler/mutating_webhook_handler.go 88.57% <0.00%> (-6.03%) ⬇️
pkg/reconciler/crd_handler.go 85.00% <0.00%> (-5.25%) ⬇️
pkg/validator/patch.go 95.40% <0.00%> (-0.60%) ⬇️
pkg/envoy/ads/stream.go 10.55% <0.00%> (-0.17%) ⬇️
pkg/validator/server.go 76.28% <0.00%> (-0.06%) ⬇️
pkg/catalog/fake.go 34.37% <0.00%> (ø)
pkg/envoy/ads/jobs.go 0.00% <0.00%> (ø)
pkg/errcode/errcode.go 100.00% <0.00%> (ø)
pkg/reconciler/types.go 0.00% <0.00%> (ø)
pkg/envoy/ads/profile.go 87.50% <0.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51f5036...f10badc. Read the comment docs.

@ksubrmnn ksubrmnn marked this pull request as ready for review September 27, 2021 17:00
@ksubrmnn ksubrmnn merged commit b7eb06f into openservicemesh:main Sep 27, 2021
@ksubrmnn ksubrmnn deleted the psp branch September 27, 2021 17:13
snehachhabria pushed a commit to snehachhabria/osm that referenced this pull request Oct 14, 2021
Signed-off-by: Kalya Subramanian <[email protected]>
Signed-off-by: Sneha Chhabria <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove PSP for OSM in 1.0.0
5 participants