This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
envoy/eds: respond to EDS request for cluster with no endpoints #4085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's possible for a cluster created via CDS to have no endpoints, such as an apex service referenced in a traffic split resource that is not backed by any pods. Respond to the EDS request for such a cluster with no endpoints so that Envoy does not keep requesting for it. Signed-off-by: Shashank Ram <[email protected]>
snehachhabria
approved these changes
Sep 9, 2021
nojnhuh
approved these changes
Sep 9, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
It's possible for a cluster created via CDS to have no endpoints,
such as an apex service referenced in a traffic split resource
that is not backed by any pods. Respond to the EDS request
for such a cluster with no endpoints so that Envoy does
not keep requesting for it.
Also updates the test to check for all fields in the expected
cluster load assignment.
Without this change, Envoy will keep requesting for the missing
EDS resource and the following log will be seen repeatedly:
Testing done:
Locally verified the change.
Affected area:
Please answer the following questions with yes/no.
Does this change contain code from or inspired by another project?
noIs this a breaking change?
no