Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

charts/osm: add namespace to preset-mesh-config resource #4084

Merged
merged 1 commit into from
Sep 8, 2021

Conversation

shashankram
Copy link
Member

Description:
The preset-mesh-config resource was not namespaced.
Resolves #4083

Affected area:

Functional Area
Install [X]

Please answer the following questions with yes/no.

  1. Does this change contain code from or inspired by another project? no

    • Did you notify the maintainers and provide attribution?
  2. Is this a breaking change? no

The preset-mesh-config resource was not namespaced.
Resolves openservicemesh#4083

Signed-off-by: Shashank Ram <[email protected]>
@shashankram shashankram added the backport-to/release=v0.10 Backport to release v0.10 label Sep 8, 2021
@shashankram shashankram requested a review from a team as a code owner September 8, 2021 22:59
@codecov-commenter
Copy link

codecov-commenter commented Sep 8, 2021

Codecov Report

Merging #4084 (68c990d) into main (9587d45) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4084      +/-   ##
==========================================
+ Coverage   69.03%   69.08%   +0.04%     
==========================================
  Files         205      205              
  Lines       11242    11242              
==========================================
+ Hits         7761     7766       +5     
+ Misses       3429     3424       -5     
  Partials       52       52              
Flag Coverage Δ
unittests 69.08% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/crdconversion/crdconversion.go 75.00% <0.00%> (+5.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9587d45...68c990d. Read the comment docs.

@shashankram shashankram merged commit 22f7049 into openservicemesh:main Sep 8, 2021
@shashankram shashankram deleted the fix-ns branch September 8, 2021 23:59
shashankram added a commit to shashankram/osm that referenced this pull request Sep 9, 2021
…mesh#4084)

The preset-mesh-config resource was not namespaced.
Resolves openservicemesh#4083

Signed-off-by: Shashank Ram <[email protected]>
shashankram added a commit that referenced this pull request Sep 9, 2021
[backport] charts/osm: add namespace to preset-mesh-config resource (#4084)
@shashankram shashankram removed the backport-to/release=v0.10 Backport to release v0.10 label Sep 9, 2021
@shashankram
Copy link
Member Author

This change was backported to release-v0.10.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

preset-mesh-config needs to use namespace value from values.yaml
4 participants