Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

errcode: remove unused error codes #4077

Merged
merged 1 commit into from
Sep 7, 2021

Conversation

shashankram
Copy link
Member

Description:
A lot of unused error paths were cleaned up as a
part of refactoring efforts. This change removes
unused error codes.

Affected area:

Functional Area
Control Plane [X]

Please answer the following questions with yes/no.

  1. Does this change contain code from or inspired by another project? no

    • Did you notify the maintainers and provide attribution?
  2. Is this a breaking change? no

A lot of unused error paths were cleaned up as a
part of refactoring efforts. This change removes
unused error codes.

Signed-off-by: Shashank Ram <[email protected]>
@shashankram shashankram requested a review from a team as a code owner September 7, 2021 20:49
@codecov-commenter
Copy link

Codecov Report

Merging #4077 (e922129) into main (0288571) will decrease coverage by 0.12%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4077      +/-   ##
==========================================
- Coverage   69.04%   68.92%   -0.13%     
==========================================
  Files         205      205              
  Lines       11247    11249       +2     
==========================================
- Hits         7766     7753      -13     
- Misses       3429     3444      +15     
  Partials       52       52              
Flag Coverage Δ
unittests 68.92% <0.00%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/envoy/eds/response.go 47.69% <0.00%> (-1.52%) ⬇️
pkg/errcode/errcode.go 100.00% <ø> (ø)
pkg/crdconversion/crdconversion.go 59.78% <0.00%> (-15.22%) ⬇️
pkg/certificate/rotor/rotor.go 87.50% <0.00%> (+3.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0288571...e922129. Read the comment docs.

@shashankram shashankram merged commit ed71553 into openservicemesh:main Sep 7, 2021
@shashankram shashankram deleted the unused-errcode branch September 7, 2021 21:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants