This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
demo: Fixing incorrect log line - should be generalized to 'web server' #4067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Delyan Raychev <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #4067 +/- ##
==========================================
+ Coverage 68.32% 68.43% +0.11%
==========================================
Files 206 206
Lines 11671 11671
==========================================
+ Hits 7974 7987 +13
+ Misses 3647 3634 -13
Partials 50 50
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
nojnhuh
approved these changes
Sep 1, 2021
trstringer
approved these changes
Sep 1, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a small log issue, where the
bookbuyerpod claims it isbookstore, which is not true.The fix generalized the message to announce that a 'Web server' is running, not specifically bookbuyer or a booskstore.
Example:
