This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
endpoints: don't filter service endpoints in permissive mode #4066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, permissive mode bypasses EDS and uses Envoy's OriginalDestination cluster for service discovery. As a part of implementing support for TrafficSplit in permissive mode, permissive mode will also leverage EDS for endpoint discovery. The existing API leveraged by EDS to discover the endpoints of a service are not usable for permissive mode, so this change adds support for the same. This change also renames the function for clarity and removes an implicit comment. Required by openservicemesh#4052 and openservicemesh#2527. Signed-off-by: Shashank Ram <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #4066 +/- ##
==========================================
+ Coverage 68.32% 68.44% +0.12%
==========================================
Files 206 206
Lines 11671 11673 +2
==========================================
+ Hits 7974 7990 +16
+ Misses 3647 3633 -14
Partials 50 50
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
allenlsy
reviewed
Sep 1, 2021
| func (mc *MeshCatalog) ListEndpointsForServiceIdentity(downstreamIdentity identity.ServiceIdentity, upstreamSvc service.MeshService) ([]endpoint.Endpoint, error) { | ||
| // ListAllowedUpstreamEndpointsForService returns the list of endpoints over which the downstream client identity | ||
| // is allowed access the upstream service | ||
| func (mc *MeshCatalog) ListAllowedUpstreamEndpointsForService(downstreamIdentity identity.ServiceIdentity, upstreamSvc service.MeshService) ([]endpoint.Endpoint, error) { |
There was a problem hiding this comment.
In this issue #3190, we discussed about dropping the word allowed from method names. Basically we don't return endpoints that are not allowed.
There was a problem hiding this comment.
For permissive mode, everything is allowed. For SMI, a subset of endpoints is allowed. Hope that makes sense.
nojnhuh
approved these changes
Sep 1, 2021
allenlsy
approved these changes
Sep 1, 2021
snehachhabria
approved these changes
Sep 1, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Currently, permissive mode bypasses EDS and uses Envoy's
OriginalDestination cluster for service discovery.
As a part of implementing support for TrafficSplit in
permissive mode, permissive mode will also leverage
EDS for endpoint discovery. The existing API leveraged
by EDS to discover the endpoints of a service are
not usable for permissive mode, so this change adds
support for the same.
This change also renames the function for clarity
and removes an implicit comment.
Required by #4052 and #2527.
Testing done:
Unit tests and verified permissive mode with local changes.
Affected area:
Please answer the following questions with yes/no.
Does this change contain code from or inspired by another project?
noIs this a breaking change?
no