This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
feat(windows): Make Egress test pass on Windows #4022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davinci26
force-pushed
the
windowsEgressTest
branch
from
72a0008 to
e7a653c
Compare
michelleN
suggested changes
Aug 23, 2021
davinci26
commented
Aug 23, 2021
ksubrmnn
reviewed
Aug 23, 2021
shashankram
suggested changes
Aug 23, 2021
davinci26
force-pushed
the
windowsEgressTest
branch
2 times, most recently
from
8d0d6f9 to
cbeaf91
Compare
shashankram
approved these changes
Aug 23, 2021
ksubrmnn
reviewed
Aug 23, 2021
ksubrmnn
reviewed
Aug 23, 2021
This PR modifies the `e2e_egress_test` to be able to run on Windows nodes
Verified locally in an AKS cluster:
```
Ran 1 of 42 Specs in 471.548 seconds
SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 41 Skipped
--- PASS: TestSuite (471.56s)
```
Signed-off-by: Sotiris Nanopoulos <[email protected]>
davinci26
force-pushed
the
windowsEgressTest
branch
from
cbeaf91 to
4af84fb
Compare
Codecov Report
@@ Coverage Diff @@
## main #4022 +/- ##
==========================================
+ Coverage 67.28% 67.85% +0.57%
==========================================
Files 205 205
Lines 11559 11569 +10
==========================================
+ Hits 7777 7850 +73
+ Misses 3731 3668 -63
Partials 51 51
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
ksubrmnn
approved these changes
Aug 23, 2021
michelleN
approved these changes
Aug 24, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the
e2e_egress_testto be able to run on Windows nodesVerified locally in an AKS cluster:
Signed-off-by: Sotiris Nanopoulos [email protected]
Description:
Testing done:
Affected area:
Please answer the following questions with yes/no.
Does this change contain code from or inspired by another project?
Is this a breaking change?