This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 276
feat(e2e): Remove dependency on oc for SCC #4014
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kalya Subramanian <[email protected]>
shashankram
reviewed
Aug 19, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you un-export all the functions added in this change that are pkg scoped to tests/framework
.
nshankar13
approved these changes
Aug 20, 2021
Signed-off-by: Kalya Subramanian <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #4014 +/- ##
=======================================
Coverage 67.54% 67.54%
=======================================
Files 204 204
Lines 11611 11611
=======================================
Hits 7843 7843
Misses 3717 3717
Partials 51 51
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
eduser25
approved these changes
Aug 20, 2021
@Mergifyio backport release-v0.9 |
mergify bot
pushed a commit
that referenced
this pull request
Aug 25, 2021
* feat(e2e): Remove dependency on oc for SCC Signed-off-by: Kalya Subramanian <[email protected]> (cherry picked from commit ac3857d) # Conflicts: # tests/framework/common.go
Command
|
ksubrmnn
added a commit
to ksubrmnn/osm
that referenced
this pull request
Aug 25, 2021
* feat(e2e): Remove dependency on oc for SCC Signed-off-by: Kalya Subramanian <[email protected]> (cherry picked from commit ac3857d) Signed-off-by: Kalya Subramanian <[email protected]>
ksubrmnn
added a commit
that referenced
this pull request
Aug 25, 2021
* feat(e2e): Remove dependency on oc for SCC Signed-off-by: Kalya Subramanian <[email protected]> (cherry picked from commit ac3857d) Signed-off-by: Kalya Subramanian <[email protected]> Co-authored-by: Kalya Subramanian <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kalya Subramanian [email protected]
Description:
Removes dependency on oc binary by using the client-go API directly to program SecurityContextConstraints for OpenShift
Fixes #3999
Testing done:
Affected area:
Please answer the following questions with yes/no.
No
No