Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

feat(e2e): Remove dependency on oc for SCC #4014

Merged
merged 2 commits into from
Aug 20, 2021

Conversation

ksubrmnn
Copy link
Contributor

Signed-off-by: Kalya Subramanian [email protected]

Description:
Removes dependency on oc binary by using the client-go API directly to program SecurityContextConstraints for OpenShift
Fixes #3999

Testing done:

Affected area:

Functional Area
New Functionality [ ]
CI System [ ]
CLI Tool [ ]
Certificate Management [ ]
Control Plane [ ]
Demo [ ]
Documentation [ ]
Egress [ ]
Ingress [ ]
Install [ ]
Networking [ ]
Observability [ ]
Performance [ ]
SMI Policy [ ]
Security [ ]
Sidecar Injection [ ]
Tests [X]
Upgrade [ ]
Other [ ]

Please answer the following questions with yes/no.

  1. Does this change contain code from or inspired by another project?
    • Did you notify the maintainers and provide attribution?
      No
  2. Is this a breaking change?
    No

@ksubrmnn ksubrmnn requested a review from a team as a code owner August 19, 2021 22:35
Copy link
Member

@shashankram shashankram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you un-export all the functions added in this change that are pkg scoped to tests/framework.

Signed-off-by: Kalya Subramanian <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Merging #4014 (6d9315c) into main (7e580ef) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4014   +/-   ##
=======================================
  Coverage   67.54%   67.54%           
=======================================
  Files         204      204           
  Lines       11611    11611           
=======================================
  Hits         7843     7843           
  Misses       3717     3717           
  Partials       51       51           
Flag Coverage Δ
unittests 67.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e580ef...6d9315c. Read the comment docs.

@ksubrmnn ksubrmnn merged commit ac3857d into openservicemesh:main Aug 20, 2021
@ksubrmnn ksubrmnn deleted the oc_e2e branch August 20, 2021 19:15
@ksubrmnn
Copy link
Contributor Author

@Mergifyio backport release-v0.9

mergify bot pushed a commit that referenced this pull request Aug 25, 2021
* feat(e2e): Remove dependency on oc for SCC

Signed-off-by: Kalya Subramanian <[email protected]>
(cherry picked from commit ac3857d)

# Conflicts:
#	tests/framework/common.go
@mergify
Copy link
Contributor

mergify bot commented Aug 25, 2021

Command backport release-v0.9: success

Backports have been created

ksubrmnn added a commit to ksubrmnn/osm that referenced this pull request Aug 25, 2021
* feat(e2e): Remove dependency on oc for SCC

Signed-off-by: Kalya Subramanian <[email protected]>
(cherry picked from commit ac3857d)
Signed-off-by: Kalya Subramanian <[email protected]>
ksubrmnn added a commit that referenced this pull request Aug 25, 2021
* feat(e2e): Remove dependency on oc for SCC

Signed-off-by: Kalya Subramanian <[email protected]>
(cherry picked from commit ac3857d)
Signed-off-by: Kalya Subramanian <[email protected]>

Co-authored-by: Kalya Subramanian <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove oc dependency from E2Es
5 participants