This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
ingress: don't error if candidate group version is not available #4007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a candidate API GroupVersion (ex. networking.k8s.io/v1beta1) is not available, don't error. Only error if none of the candidates are available (already the case). This is required for OSM to work in k8s v1.22, where the networking.k8s.io/v1beta1 is deprecated. Signed-off-by: Shashank Ram <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #4007 +/- ##
=======================================
Coverage 67.53% 67.53%
=======================================
Files 204 204
Lines 11615 11611 -4
=======================================
- Hits 7844 7842 -2
+ Misses 3720 3718 -2
Partials 51 51
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
snehachhabria
approved these changes
Aug 18, 2021
trstringer
approved these changes
Aug 18, 2021
shashankram
added a commit
to shashankram/osm
that referenced
this pull request
Aug 18, 2021
…nservicemesh#4007) If a candidate API GroupVersion (ex. networking.k8s.io/v1beta1) is not available, don't error. Only error if none of the candidates are available (already the case). This is required for OSM to work in k8s v1.22, where the networking.k8s.io/v1beta1 is deprecated. Signed-off-by: Shashank Ram <[email protected]>
shashankram
added a commit
that referenced
this pull request
Aug 19, 2021
…) (#4008) If a candidate API GroupVersion (ex. networking.k8s.io/v1beta1) is not available, don't error. Only error if none of the candidates are available (already the case). This is required for OSM to work in k8s v1.22, where the networking.k8s.io/v1beta1 is deprecated. Signed-off-by: Shashank Ram <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
If a candidate API GroupVersion (ex. networking.k8s.io/v1beta1) is not
available, don't error. Only error if none of the candidates are
available (already the case).
This is required for OSM to work in k8s v1.22, where the
networking.k8s.io/v1beta1 is deprecated.
Affected area:
Please answer the following questions with yes/no.
Does this change contain code from or inspired by another project?
noIs this a breaking change?
no