This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
Add tracing options when Jaeger deployment is enabled for the demo script #3947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tracing support from the demo run script Signed-off-by: Thomas Stringer <[email protected]>
Signed-off-by: Thomas Stringer <[email protected]>
shashankram
suggested changes
Aug 11, 2021
Signed-off-by: Thomas Stringer <[email protected]>
Signed-off-by: Thomas Stringer <[email protected]>
shashankram
approved these changes
Aug 11, 2021
Codecov Report
@@ Coverage Diff @@
## main #3947 +/- ##
==========================================
+ Coverage 67.45% 67.49% +0.04%
==========================================
Files 202 202
Lines 11543 11543
==========================================
+ Hits 7786 7791 +5
+ Misses 3707 3702 -5
Partials 50 50
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
snehachhabria
approved these changes
Aug 11, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Currently the demo script will deploy Jaeger if the
DEPLOY_JAEGERenv var is set. However, there is no logic to enableOpenServiceMesh.tracing.enableand set the tracing endpoint. This PR introduces that so the script user doesn't have any other additional steps to enable the tracing component.Affected area:
Testing done:
Ran the demo script and observed the tracing.
Please answer the following questions with yes/no.
No.
No.