This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
test/ads: fix unit test flakyness #3906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR openservicemesh#3803 introduced a mapset (backed by golang map) to slice conversion, which does not guarantee same output ordering for the same input, thus was making a unit test fail from time to time. This commit forces output of the slice to be alphabetically ordered, ensuring determinism of the output slice for the same input mapset. Signed-off-by: Eduard Serra <[email protected]>
eduser25
changed the title
Codecov Report
@@ Coverage Diff @@
## main #3906 +/- ##
==========================================
+ Coverage 67.43% 67.47% +0.04%
==========================================
Files 202 202
Lines 11385 11386 +1
==========================================
+ Hits 7677 7683 +6
+ Misses 3657 3652 -5
Partials 51 51
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
shalier
approved these changes
Aug 2, 2021
allenlsy
approved these changes
Aug 2, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #3803 introduced a mapset (backed by golang map) to slice conversion,
which does not guarantee same output ordering for the same input,
thus was making a unit test fail from time to time.
This commit forces output of the slice to be alphabetically ordered,
ensuring determinism of the output slice for the same input mapset.
Signed-off-by: Eduard Serra [email protected]
| Tests | [x] |
No
No