This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
feat(windows): Make local clusters use localhostIP instead of wildcardIP #3893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Windows (unlike linux) do not allow sockets to connect to wildcardIP (0.0.0.0). So Envoy clusters that use address 0.0.0.0 will fail on Windows workers. With this PR we change those tests to use localhostIP. Validated through unit tests and the CI. Fixes openservicemesh#3882 Signed-off-by: Sotiris Nanopoulos <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #3893 +/- ##
==========================================
+ Coverage 67.59% 67.63% +0.04%
==========================================
Files 201 201
Lines 11173 11337 +164
==========================================
+ Hits 7552 7668 +116
- Misses 3571 3618 +47
- Partials 50 51 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
draychev
approved these changes
Jul 30, 2021
shashankram
approved these changes
Jul 30, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows (unlike linux) does not allow sockets to connect to wildcardIP (0.0.0.0).
So Envoy clusters that use address 0.0.0.0 will fail on Windows workers. With this PR
we change those tests to use localhostIP.
Validated through unit tests and the CI. Fixes #3882
Signed-off-by: Sotiris Nanopoulos [email protected]