Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

ref(install): Log namespace for existing mesh #3846

Merged
merged 1 commit into from
Jul 23, 2021

Conversation

ksubrmnn
Copy link
Contributor

Signed-off-by: Kalya Subramanian [email protected]

Description:
Makes error messages more clear about existing meshes when there is an existing mesh that conflicts with the new install.

Affected area:

Functional Area
New Functionality [ ]
Documentation [ ]
Install [X]
CLI Tool [X]
Certificate Management [ ]
Control Plane [ ]
Ingress [ ]
Egress [ ]
Networking [ ]
Observability [ ]
SMI Policy [ ]
Sidecar Injection [ ]
Security [ ]
Upgrade [ ]
Tests [ ]
CI System [ ]
Demo [ ]
Performance [ ]
Other [ ]

Please answer the following questions with yes/no.

  1. Does this change contain code from or inspired by another project?
    • Did you notify the maintainers and provide attribution?
      No
  2. Is this a breaking change?
    No

@ksubrmnn ksubrmnn requested a review from a team as a code owner July 23, 2021 17:40
@codecov-commenter
Copy link

Codecov Report

Merging #3846 (1b549bf) into main (34d4b6d) will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3846      +/-   ##
==========================================
+ Coverage   67.63%   67.70%   +0.07%     
==========================================
  Files         198      198              
  Lines       11034    11034              
==========================================
+ Hits         7463     7471       +8     
+ Misses       3521     3514       -7     
+ Partials       50       49       -1     
Flag Coverage Δ
unittests 67.70% <100.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/cli/install.go 84.00% <100.00%> (ø)
pkg/crdconversion/crdconversion.go 69.56% <0.00%> (+8.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34d4b6d...1b549bf. Read the comment docs.

@ksubrmnn ksubrmnn merged commit c3c38a0 into openservicemesh:main Jul 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants