Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

service: Simplify and test MeshService.FQDN() #3826

Merged
merged 3 commits into from
Jul 21, 2021

Conversation

draychev
Copy link
Contributor

This PR is an attempt to improve the readability of FQDN(). But most importantly - test it and show what it produces.

Signed-off-by: Delyan Raychev [email protected]

@draychev draychev requested a review from a team as a code owner July 21, 2021 20:55
@codecov-commenter
Copy link

Codecov Report

Merging #3826 (8bbbe98) into main (94394bd) will increase coverage by 0.19%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3826      +/-   ##
==========================================
+ Coverage   67.38%   67.58%   +0.19%     
==========================================
  Files         198      198              
  Lines       10978    10978              
==========================================
+ Hits         7398     7419      +21     
+ Misses       3531     3510      -21     
  Partials       49       49              
Flag Coverage Δ
unittests 67.58% <100.00%> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/service/types.go 50.00% <100.00%> (+21.42%) ⬆️
...icate/providers/certmanager/certificate_manager.go 86.61% <0.00%> (+0.70%) ⬆️
pkg/crdconversion/crdconversion.go 59.78% <0.00%> (+18.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94394bd...8bbbe98. Read the comment docs.

pkg/service/types.go Outdated Show resolved Hide resolved
draychev and others added 2 commits July 21, 2021 14:21
Co-authored-by: Shashank Ram <[email protected]>
Signed-off-by: Delyan Raychev <[email protected]>
@draychev draychev requested a review from shashankram July 21, 2021 21:24
@draychev draychev merged commit b370fa2 into openservicemesh:main Jul 21, 2021
@draychev draychev deleted the tiny-refactor-9 branch July 21, 2021 23:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants