This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
catalog: Refactor buildOutboundPolicies() #3794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Delyan Raychev <[email protected]>
draychev
force-pushed
the
multicluster-22
branch
from
6c9cf7f to
d7fc0cf
Compare
shashankram
approved these changes
Jul 19, 2021
Codecov Report
@@ Coverage Diff @@
## main #3794 +/- ##
==========================================
- Coverage 68.42% 68.41% -0.01%
==========================================
Files 188 188
Lines 10748 10749 +1
==========================================
Hits 7354 7354
- Misses 3345 3346 +1
Partials 49 49
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
shalier
approved these changes
Jul 19, 2021
snehachhabria
approved these changes
Jul 19, 2021
Co-authored-by: Shashank Ram <[email protected]>
Co-authored-by: Shashank Ram <[email protected]>
Signed-off-by: Delyan Raychev <[email protected]>
draychev
force-pushed
the
multicluster-22
branch
from
b907990 to
0dcad51
Compare
allenlsy
approved these changes
Jul 19, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes
if !mc.isTrafficSplitApexService(destService) {if mc.isTrafficSplitApexService(destService) {+continue** no functional code changes**
This PR simply removes a level of indentation!