This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
multicluster: Defaulting demo to Tresor certificate issuer #3767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Delyan Raychev <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #3767 +/- ##
==========================================
- Coverage 69.98% 69.77% -0.22%
==========================================
Files 185 185
Lines 10366 10406 +40
==========================================
+ Hits 7255 7261 +6
- Misses 3062 3096 +34
Partials 49 49
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
shashankram
reviewed
Jul 14, 2021
Signed-off-by: Delyan Raychev <[email protected]>
shashankram
approved these changes
Jul 14, 2021
jaellio
approved these changes
Jul 14, 2021
allenlsy
approved these changes
Jul 15, 2021
shashankram
pushed a commit
to shashankram/osm
that referenced
this pull request
Jul 15, 2021
…cemesh#3767) * multicluster: Defaulting demo to Tresor certificate issuer Signed-off-by: Delyan Raychev <[email protected]> * Remove explicitly setting tresor Signed-off-by: Delyan Raychev <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes optionality of running OSM Multicluster w/ other cert issues.
This PR hard-codes
tresoras the only Multicluster demo cert issuer.The goal is to simplify.
Signed-off-by: Delyan Raychev [email protected]