Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

test(e2e): Configure e2e ports for OpenShift #3748

Merged
merged 2 commits into from
Jul 8, 2021

Conversation

ksubrmnn
Copy link
Contributor

@ksubrmnn ksubrmnn commented Jul 8, 2021

Signed-off-by: Kalya Subramanian [email protected]

Description:
Use port 14001 for e2e traffic split test so that server/client communication works on OpenShift which reserves port 80.

Partially addresses #3097

Affected area:

Functional Area
New Functionality [ ]
Documentation [ ]
Install [ ]
CLI Tool [ ]
Certificate Management [ ]
Control Plane [ ]
Ingress [ ]
Egress [ ]
Networking [ ]
Observability [ ]
SMI Policy [ ]
Sidecar Injection [ ]
Security [ ]
Upgrade [ ]
Tests [X]
CI System [ ]
Demo [ ]
Performance [ ]
Other [ ]

Please answer the following questions with yes/no.

  1. Does this change contain code from or inspired by another project?
    • Did you notify the maintainers and provide attribution?
      No
  2. Is this a breaking change?
    No

@ksubrmnn ksubrmnn requested a review from a team as a code owner July 8, 2021 19:03
@codecov-commenter
Copy link

codecov-commenter commented Jul 8, 2021

Codecov Report

Merging #3748 (356cd27) into main (278c519) will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3748      +/-   ##
==========================================
+ Coverage   69.54%   69.60%   +0.05%     
==========================================
  Files         185      185              
  Lines        9035     9033       -2     
==========================================
+ Hits         6283     6287       +4     
+ Misses       2703     2697       -6     
  Partials       49       49              
Flag Coverage Δ
unittests 69.60% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/catalog/endpoint.go 70.00% <0.00%> (-1.43%) ⬇️
pkg/k8s/announcement_handlers.go 77.14% <0.00%> (+5.71%) ⬆️
pkg/crdconversion/crdconversion.go 70.31% <0.00%> (+6.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 278c519...356cd27. Read the comment docs.

Signed-off-by: Kalya Subramanian <[email protected]>
@ksubrmnn ksubrmnn merged commit 6e19645 into openservicemesh:main Jul 8, 2021
@ksubrmnn ksubrmnn deleted the e2e_port branch July 8, 2021 23:48
shashankram pushed a commit to shashankram/osm that referenced this pull request Jul 15, 2021
* test(e2e): Configure e2e ports for OpenShift

Signed-off-by: Kalya Subramanian <[email protected]>
@ksubrmnn ksubrmnn linked an issue Jul 20, 2021 that may be closed by this pull request
@nshankar13
Copy link
Contributor

@Mergifyio backport release-v0.9

mergify bot pushed a commit that referenced this pull request Jul 27, 2021
* test(e2e): Configure e2e ports for OpenShift

Signed-off-by: Kalya Subramanian <[email protected]>
(cherry picked from commit 6e19645)
@mergify
Copy link
Contributor

mergify bot commented Jul 27, 2021

Command backport release-v0.9: success

Backports have been created

nshankar13 added a commit that referenced this pull request Jul 27, 2021
…/pr-3748

test(e2e): Configure e2e ports for OpenShift (backport #3748)
nshankar13 pushed a commit that referenced this pull request Jul 27, 2021
* test(e2e): Configure e2e ports for OpenShift

Signed-off-by: Kalya Subramanian <[email protected]>
(cherry picked from commit 6e19645)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configure e2es to run on OpenShift
5 participants