Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

tests: enable priv init container for upgrade on openshift #3738

Merged
merged 1 commit into from
Jul 8, 2021

Conversation

SanyaKochhar
Copy link
Contributor

Description: Sets enablePrivilegedInitContainer to true if test is run on an OpenShift cluster

Affected area:

Functional Area
New Functionality [ ]
Documentation [ ]
Install [ ]
CLI Tool [ ]
Certificate Management [ ]
Control Plane [ ]
Ingress [ ]
Egress [ ]
Networking [ ]
Observability [ ]
SMI Policy [ ]
Sidecar Injection [ ]
Security [ ]
Upgrade [ ]
Tests [x]
CI System [ ]
Demo [ ]
Performance [ ]
Other [ ]

Please answer the following questions with yes/no.

  1. Does this change contain code from or inspired by another project? no

    • Did you notify the maintainers and provide attribution?
  2. Is this a breaking change?
    no

@SanyaKochhar SanyaKochhar requested a review from a team as a code owner July 7, 2021 18:16
@codecov-commenter
Copy link

codecov-commenter commented Jul 7, 2021

Codecov Report

Merging #3738 (496435c) into main (0322387) will increase coverage by 2.09%.
The diff coverage is 58.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3738      +/-   ##
==========================================
+ Coverage   67.65%   69.75%   +2.09%     
==========================================
  Files         181      185       +4     
  Lines        8772     8989     +217     
==========================================
+ Hits         5935     6270     +335     
+ Misses       2804     2670     -134     
- Partials       33       49      +16     
Flag Coverage Δ
unittests 69.75% <58.66%> (+2.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/cli/mesh_upgrade.go 70.83% <ø> (+25.00%) ⬆️
cmd/osm-controller/log_handler.go 77.77% <0.00%> (-6.23%) ⬇️
cmd/osm-controller/osm-controller.go 13.07% <0.00%> (-0.45%) ⬇️
pkg/catalog/egress.go 83.89% <0.00%> (-3.72%) ⬇️
pkg/catalog/inbound_traffic_policies.go 78.81% <0.00%> (-4.23%) ⬇️
pkg/catalog/traffictarget.go 88.46% <0.00%> (ø)
pkg/constants/constants.go 0.00% <ø> (ø)
pkg/endpoint/mock_endpoint_provider_generated.go 0.00% <ø> (ø)
pkg/endpoint/types.go 100.00% <ø> (ø)
pkg/providers/kube/fake.go 0.00% <0.00%> (ø)
... and 48 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 038f093...496435c. Read the comment docs.

@SanyaKochhar SanyaKochhar merged commit 1f174c9 into openservicemesh:main Jul 8, 2021
@ksubrmnn ksubrmnn linked an issue Jul 27, 2021 that may be closed by this pull request
@ksubrmnn ksubrmnn changed the title tests: enable priv init container for tests on openshift tests: enable priv init container for upgrade on openshift Jul 27, 2021
@nshankar13
Copy link
Contributor

@Mergifyio backport release-v0.9

@mergify
Copy link
Contributor

mergify bot commented Jul 27, 2021

Command backport release-v0.9: success

Backports have been created

nshankar13 added a commit that referenced this pull request Jul 27, 2021
…/pr-3738

tests: enable priv init container for upgrade on openshift (backport #3738)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configure e2es to run on OpenShift
5 participants