This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
fix: patch backporting PR for meshconfig changes #3640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaellio
commented
Jun 22, 2021
Codecov Report
@@ Coverage Diff @@
## release-v0.9 #3640 +/- ##
================================================
- Coverage 66.44% 66.41% -0.03%
================================================
Files 168 168
Lines 7912 7912
================================================
- Hits 5257 5255 -2
- Misses 2624 2626 +2
Partials 31 31
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Adds enablePrometheusScraping back to values.schema.json. Since osm mesh upgrade reuses values from previous releases, the enablePrometheusScraping flag must remain in the values schema to avoid errors on upgrade even though it is no longer used in the codebase. Signed-off-by: jaellio <[email protected]>
nojnhuh
approved these changes
Jun 22, 2021
snehachhabria
approved these changes
Jun 22, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adds enablePrometheusScraping back to values.schema.json. Since
osm mesh upgrade reuses values from previous releases, the
enablePrometheusScraping flag must remain in the values schema to
avoid errors on upgrade even though it is no longer used in the
codebase.
Affected area:
Please answer the following questions with yes/no.
Does this change contain code from or inspired by another project? No
Is this a breaking change? No