Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

fix(uninstall): Add nodeSelectors for osm-cleanup #3624

Closed
wants to merge 1 commit into from

Conversation

ksubrmnn
Copy link
Contributor

Signed-off-by: Kalya Subramanian [email protected]

Description:

Adds node selector to osm cleanup job
Fixes #3509

Affected area:

Functional Area
New Functionality [ ]
Documentation [ ]
Install [X]
CLI Tool [ ]
Certificate Management [ ]
Control Plane []
Ingress [ ]
Egress [ ]
Networking [ ]
Observability [ ]
SMI Policy [ ]
Sidecar Injection [ ]
Security [ ]
Upgrade [ ]
Tests [ ]
CI System [ ]
Demo [ ]
Performance [ ]
Other [ ]

Please answer the following questions with yes/no.

  1. Does this change contain code from or inspired by another project?
    • Did you notify the maintainers and provide attribution?
      No
  2. Is this a breaking change?
    No

@ksubrmnn ksubrmnn requested a review from a team as a code owner June 18, 2021 19:56
@codecov-commenter
Copy link

Codecov Report

Merging #3624 (575edef) into main (113bfc3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3624   +/-   ##
=======================================
  Coverage   67.72%   67.72%           
=======================================
  Files         177      177           
  Lines        8593     8593           
=======================================
  Hits         5820     5820           
  Misses       2742     2742           
  Partials       31       31           
Flag Coverage Δ
unittests 67.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 113bfc3...575edef. Read the comment docs.

@ksubrmnn ksubrmnn closed this Jun 18, 2021
@ksubrmnn
Copy link
Contributor Author

Duplicate of #3622

@ksubrmnn ksubrmnn marked this as a duplicate of #3622 Jun 18, 2021
@ksubrmnn ksubrmnn deleted the nodeSelector branch June 18, 2021 20:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Linux node selectors to control plane components
3 participants