Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

fix(install): Add nodeSelectors for install and demo #3611

Merged
merged 1 commit into from
Jun 17, 2021

Conversation

ksubrmnn
Copy link
Contributor

@ksubrmnn ksubrmnn commented Jun 16, 2021

Signed-off-by: Kalya Subramanian [email protected]

Description:
Fixes #3509

Adds nodeSelectors to control plane components and demo apps so that they are not scheduled on the wrong nodes in mixedOS clusters

Affected area:

Functional Area
New Functionality [ ]
Documentation [ ]
Install [X]
CLI Tool [ ]
Certificate Management [ ]
Control Plane [ ]
Ingress [ ]
Egress [ ]
Networking [ ]
Observability [ ]
SMI Policy [ ]
Sidecar Injection [ ]
Security [ ]
Upgrade [ ]
Tests [ ]
CI System [ ]
Demo [X]
Performance [ ]
Other [ ]

Please answer the following questions with yes/no.

  1. Does this change contain code from or inspired by another project?
    • Did you notify the maintainers and provide attribution?
      No
  2. Is this a breaking change?
    No

@ksubrmnn ksubrmnn requested a review from a team as a code owner June 16, 2021 22:39
@codecov-commenter
Copy link

Codecov Report

Merging #3611 (1346917) into main (ed55003) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3611   +/-   ##
=======================================
  Coverage   66.98%   66.98%           
=======================================
  Files         177      177           
  Lines        8589     8589           
=======================================
  Hits         5753     5753           
  Misses       2805     2805           
  Partials       31       31           
Flag Coverage Δ
unittests 66.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed55003...1346917. Read the comment docs.

@ksubrmnn ksubrmnn merged commit 94fc23d into openservicemesh:main Jun 17, 2021
@ksubrmnn ksubrmnn deleted the nodeSelector branch June 17, 2021 16:35
ksubrmnn added a commit to ksubrmnn/osm that referenced this pull request Jun 18, 2021
ksubrmnn added a commit that referenced this pull request Jun 18, 2021
* fix(install): Add nodeSelectors for install and demo (#3611)

Signed-off-by: Kalya Subramanian <[email protected]>

* fix(cleanup): Add nodeSelectors for cleanup-hook

Ensure that cleanup-hook is not scheduled on a Windows node

Signed-off-by: Sotiris Nanopoulos <[email protected]>

Co-authored-by: Sotiris Nanopoulos <[email protected]>
shalier pushed a commit to shalier/osm that referenced this pull request Jun 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Linux node selectors to control plane components
4 participants