Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

fix(e2e): skip e2e_init_controller_test for noInstall #3576

Conversation

nshankar13
Copy link
Contributor

Signed-off-by: nshankar13 [email protected]

Description: Skip the e2e_init_controller_test if the test suite is run with "NoInstall"

Affected area:

Functional Area
New Functionality [ ]
Documentation [ ]
Install [ ]
CLI Tool [ ]
Certificate Management [ ]
Control Plane [ ]
Ingress [ ]
Egress [ ]
Networking [ ]
Observability [ ]
SMI Policy [ ]
Sidecar Injection [ ]
Security [ ]
Upgrade [ ]
Tests [X]
CI System [X]
Demo [ ]
Performance [ ]
Other [ ]

Please answer the following questions with yes/no.

  1. Does this change contain code from or inspired by another project?

    • Did you notify the maintainers and provide attribution?
      No
  2. Is this a breaking change? No

@nshankar13 nshankar13 requested a review from a team as a code owner June 10, 2021 23:09
@codecov-commenter
Copy link

Codecov Report

Merging #3576 (cbbce3b) into main (9684c97) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3576   +/-   ##
=======================================
  Coverage   66.12%   66.12%           
=======================================
  Files         174      174           
  Lines        8309     8309           
=======================================
  Hits         5494     5494           
  Misses       2784     2784           
  Partials       31       31           
Flag Coverage Δ
unittests 66.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86ef383...cbbce3b. Read the comment docs.

Copy link
Contributor

@snehachhabria snehachhabria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nshankar13 do you plan to back port this to release-v0.9 as well ?

@nshankar13 nshankar13 merged commit a3be2c0 into openservicemesh:main Jun 10, 2021
@nshankar13
Copy link
Contributor Author

@Mergifyio backport release-v0.9

@mergify
Copy link
Contributor

mergify bot commented Jun 10, 2021

Command backport release-v0.9: success

Backports have been created

nshankar13 added a commit that referenced this pull request Jun 11, 2021
…/pr-3576

fix(e2e): skip e2e_init_controller_test for noInstall (backport #3576)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants