This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
charts/osm-rbac: add delete verb for secrets #3570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kalya Subramanian <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #3570 +/- ##
=======================================
Coverage 66.12% 66.12%
=======================================
Files 174 174
Lines 8309 8309
=======================================
Hits 5494 5494
Misses 2784 2784
Partials 31 31
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
nojnhuh
approved these changes
Jun 10, 2021
shashankram
approved these changes
Jun 10, 2021
whitneygriffith
pushed a commit
to whitneygriffith/osm
that referenced
this pull request
Jun 15, 2021
Signed-off-by: Kalya Subramanian <[email protected]> Signed-off-by: Whitney Griffith <[email protected]>
whitneygriffith
pushed a commit
to whitneygriffith/osm
that referenced
this pull request
Jun 16, 2021
Signed-off-by: Kalya Subramanian <[email protected]>
whitneygriffith
pushed a commit
to whitneygriffith/osm
that referenced
this pull request
Jun 17, 2021
Signed-off-by: Kalya Subramanian <[email protected]>
ksubrmnn
added a commit
to ksubrmnn/osm
that referenced
this pull request
Jun 21, 2021
Signed-off-by: Kalya Subramanian <[email protected]>
ksubrmnn
added a commit
that referenced
this pull request
Jun 22, 2021
Signed-off-by: Kalya Subramanian <[email protected]>
shalier
pushed a commit
to shalier/osm
that referenced
this pull request
Jun 30, 2021
Signed-off-by: Kalya Subramanian <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kalya Subramanian [email protected]
Description:
This adds the
deleteverb forsecretsfor the osm controller ClusterRole. This permission is needed by OpenShift to set the OwnerRef for envoy secrets for garbage collection.Related to #3097
Affected area:
Please answer the following questions with yes/no.
No
No