Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

fix(.mergify.yml)Fixes autorebase label #3545

Merged
merged 1 commit into from
Jun 8, 2021

Conversation

shalier
Copy link
Contributor

@shalier shalier commented Jun 8, 2021

Description:
Removes the bot_account field to allow the autorebase feature to work. Originally, the feature (to specify the account being used to do the rebasing under) was free, but now it is a subscription-only feature. Now the autorebase feature will use any OSM account in the Mergify dashboard to perform the rebasing, which is not an issue because there's only one OSM account in Mergify.
Resolves #3544

Affected area:

Functional Area
New Functionality [ ]
Documentation [ ]
Install [ ]
CLI Tool [ ]
Certificate Management [ ]
Control Plane [ ]
Ingress [ ]
Egress [ ]
Networking [ ]
Observability [ ]
SMI Policy [ ]
Sidecar Injection [ ]
Security [ ]
Upgrade [ ]
Tests [ ]
CI System [X ]
Demo [ ]
Performance [ ]
Other [ ]

Please answer the following questions with yes/no.

  1. Does this change contain code from or inspired by another project? No

    • Did you notify the maintainers and provide attribution?
  2. Is this a breaking change?
    No

@shalier shalier requested a review from a team as a code owner June 8, 2021 17:07
@shalier shalier force-pushed the mergifyBug branch 2 times, most recently from 7bbf00e to a09dead Compare June 8, 2021 17:12
@shalier shalier changed the title fix(.mergify.yml)Fix autorebase and add/remove checks in automerge label fix(.mergify.yml)Fixes autorebase label Jun 8, 2021
Signed-off-by: Shalier Xia <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Merging #3545 (5275416) into main (04c7667) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3545      +/-   ##
==========================================
- Coverage   66.13%   66.13%   -0.01%     
==========================================
  Files         170      170              
  Lines        8085     8082       -3     
==========================================
- Hits         5347     5345       -2     
+ Misses       2708     2707       -1     
  Partials       30       30              
Flag Coverage Δ
unittests 66.13% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/catalog/catalog.go 92.30% <0.00%> (-0.55%) ⬇️
pkg/endpoint/providers/kube/client.go 78.00% <0.00%> (-0.22%) ⬇️
cmd/osm-controller/osm-controller.go 17.29% <0.00%> (+0.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04c7667...5275416. Read the comment docs.

@shalier shalier merged commit eeddf2e into openservicemesh:main Jun 8, 2021
shalier added a commit to shalier/osm that referenced this pull request Jun 30, 2021
Removes the bot_account field to allow the autorebase feature to work. Originally, the feature (to specify the account being used to do the rebasing under) was free, but now it is a subscription-only feature. Now the autorebase feature will use any OSM account in the Mergify dashboard to perform the rebasing, which is not an issue because there's only one OSM account in Mergify.
Signed-off-by: Shalier Xia <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Autorebase label is not working
4 participants